[PATCH] D64185: [NewPM] Port FinalizeISel to the new pass manager.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/FinalizeISel.cpp:46
+char &llvm::FinalizeISelID = FinalizeISelLegacyPass::ID;
+INITIALIZE_PASS(FinalizeISelLegacyPass, DEBUG_TYPE,
                 "Finalize ISel and expand pseudo-instructions", false, false)
----------------
czhang wrote:
> arsenm wrote:
> > Remove pass to avoid PassPass
> Again, for the sake of consistency, it may be less error-prone and confusing for future porters if we stick with the well established convention in having the ugly PassPass stick around for pass registration, ugly as it is. Basically every ported IR pass has a PassPass attached to it and it makes it clear that these are legacy passes. Of course, this probably won't even matter once all the passes are ported since it seems like the goal is to remove the legacy pass manager entirely once the transition is completed.
This isn't a well established convention. Some passes do, and some don't


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64185/new/

https://reviews.llvm.org/D64185