[PATCH] D43256: [MBP] Move a latch block with conditional exit and multi predecessors to top of loop

Thu Aug 1 16:00:29 PDT 2019

Carrot added a comment.

In D43256#1609742 <https://reviews.llvm.org/D43256#1609742>, @hans wrote:

> In D43256#1608459 <https://reviews.llvm.org/D43256#1608459>, @Carrot wrote:
>
> > In D43256#1607733 <https://reviews.llvm.org/D43256#1607733>, @ebrevnov wrote:
> >
> > > I would suggest putting the optimization under an option and disable it by default for now. Once all problems are resolved we can change the default. What do you think?
> >
> >
> > After restore to original behavior in plain mode, you can use -force-precise-rotation-cost=true to use this more aggressive loop layout.
>
>
> Is there a patch in progress for restoring to the original behaviour in non-profile mode? It would be nice if we could get this resolved soon.

Yes, some new added or modified test cases after this patch need to be adjusted. The new patch can be ready tomorrow.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43256/new/

https://reviews.llvm.org/D43256