[llvm] r367627 - Revert r366980: "[lit] Protect full test suite from FILECHECK_OPTS"

[Joel E. Denny via llvm-commits]

Author: jdenny
Date: Thu Aug  1 15:26:51 2019
New Revision: 367627

URL: http://llvm.org/viewvc/llvm-project?rev=367627&view=rev
Log:
Revert r366980: "[lit] Protect full test suite from FILECHECK_OPTS"

Windows bots are broken.  See recent D65335 and D65156 comments.

Modified:
    llvm/trunk/utils/lit/tests/lit.cfg
    llvm/trunk/utils/lit/tests/shtest-run-at-line.py

Modified: llvm/trunk/utils/lit/tests/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/lit.cfg?rev=367627&r1=367626&r2=367627&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/lit.cfg (original)
+++ llvm/trunk/utils/lit/tests/lit.cfg Thu Aug  1 15:26:51 2019
@@ -44,17 +44,10 @@ for attribute in ('llvm_tools_dir', 'lit
     if directory:
         llvm_config.with_environment('PATH', directory, append_path=True)
 
-# This test suite calls %{lit} to test lit's behavior for the sample test
-# suites in %{inputs}.  This test suite's results are then determined in part
-# by %{lit}'s textual output, which includes the output of FileCheck calls
-# within %{inputs}'s test suites.  Thus, %{lit} clears environment variables
-# that can affect FileCheck's output.
 config.substitutions.append(('%{inputs}', os.path.join(
     config.test_source_root, 'Inputs')))
-config.substitutions.append(('%{lit}',
-    "{env} %{{python}} {lit}".format(
-        env="env -u FILECHECK_OPTS -u FILECHECK_DUMP_INPUT_ON_FAILURE",
-        lit=os.path.join(lit_path, 'lit.py'))))
+config.substitutions.append(('%{lit}', "%%{python} %s" % (
+    os.path.join(lit_path, 'lit.py'),)))
 config.substitutions.append(('%{python}', '"%s"' % (sys.executable)))
 
 # Enable coverage.py reporting, assuming the coverage module has been installed

Modified: llvm/trunk/utils/lit/tests/shtest-run-at-line.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-run-at-line.py?rev=367627&r1=367626&r2=367627&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/shtest-run-at-line.py (original)
+++ llvm/trunk/utils/lit/tests/shtest-run-at-line.py Thu Aug  1 15:26:51 2019
@@ -1,7 +1,7 @@
 # Check that -vv makes the line number of the failing RUN command clear.
 # (-v is actually sufficient in the case of the internal shell.)
 #
-# RUN: not %{lit} -j 1 -vv %{inputs}/shtest-run-at-line > %t.out
+# RUN: env -u FILECHECK_OPTS not %{lit} -j 1 -vv %{inputs}/shtest-run-at-line > %t.out
 # RUN: FileCheck --input-file %t.out %s
 #
 # END.