[PATCH] D65599: Add MCRegister and use it in MCRegisterClass::contains()

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 14:02:51 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/include/llvm/MC/MCRegister.h:18
 class MCRegister {
+  unsigned Reg;
+
----------------
MCPhysReg?


================
Comment at: llvm/include/llvm/MC/MCRegister.h:21
 public:
+  MCRegister(unsigned Val = 0): Reg(Val) {}
+
----------------
MCPhysReg?


================
Comment at: llvm/include/llvm/MC/MCRegister.h:53
+  /// Return true if the specified register number is in the physical register
+  /// namespace.
+  bool isPhysical() const {
----------------
I would expect this to be trivially true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65599/new/

https://reviews.llvm.org/D65599





More information about the llvm-commits mailing list