[PATCH] D65576: [InstCombine] simplify a cmp+select using binop result equivalence
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 1 13:41:56 PDT 2019
lebedev.ri added a comment.
I'm having trouble grasping all that code duplication.
Can that be generalized+parametrized a bit?
Also, please can you add the example with explanation into that function?
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:1091
+ simplifyWithOpReplaced(FalseVal, CmpRHS, CmpLHS, Q) == TrueVal) {
+ if (auto *B = dyn_cast<BinaryOperator>(FalseVal))
+ B->dropPoisonGeneratingFlags();
----------------
Sure not `<Instruction>` ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65576/new/
https://reviews.llvm.org/D65576
More information about the llvm-commits
mailing list