[PATCH] D47770: [MVT][SVE] Add EVT strings and Type mapping

[David Greene via Phabricator via llvm-commits]

greened added inline comments.


================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:347
   case MVT::v8f64:   return VectorType::get(Type::getDoubleTy(Context), 8);
+  case MVT::nxv1i1:  return VectorType::get(Type::getInt1Ty(Context), 1, true);
+  case MVT::nxv2i1:  return VectorType::get(Type::getInt1Ty(Context), 2, true);
----------------
It would be helpful to add a comment about what `true` means, here and below:
```
return VectorType::get(Type::getInt1Ty(Context), 1, /* isScalable = */true);
```



================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:416
     return getVectorVT(
-      getVT(VTy->getElementType(), false), VTy->getNumElements());
+      getVT(VTy->getElementType(), false), VTy->getElementCount());
   }
----------------
Add a comment about what `false` means, similar to above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47770/new/

https://reviews.llvm.org/D47770