[PATCH] D65377: [FunctionAttrs] Annotate intrinsics with nosync

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 11:51:30 PDT 2019


jdoerfert added a comment.

In D65377#1610775 <https://reviews.llvm.org/D65377#1610775>, @arsenm wrote:

> I almost think intrinsics should be assumed nosync by default. I'm not thrilled at the prospect of another attribute that nearly every intrinsic needs to be annotated with


Mh, I'm not opposing that idea but also not convinced. Doing it for all makes it easier to introduce errors I guess. Do we have precedence?

If we want to do this, maybe we should make a list of attributes that need to be explicitly removed for intrinsics.
I expect not only `nosync` to be on it but also others like `willreturn`, `nofree`, `nounwind`, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65377/new/

https://reviews.llvm.org/D65377





More information about the llvm-commits mailing list