[PATCH] D60531: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate using a module map

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 11:15:27 PDT 2019


thakis added inline comments.


================
Comment at: compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py:949
   # Add built-in plugins.
+  plugin_proxy.add_plugin(ModuleMapPlugIn())
   plugin_proxy.add_plugin(SysRootFilterPlugIn())
----------------
It looks like we always unconditionally add this plugin, yet this plugin requires otool. Doesn't this break asan_symbolize.py on non-darwin? If not, why not?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60531/new/

https://reviews.llvm.org/D60531





More information about the llvm-commits mailing list