Re:?==?utf-8?q? [PATCH]?==?utf-8?q? D65585: WIP:?==?utf-8?q? [llvm-locstats] Add the llvm-locstats tool

[Djordje Todorovic via llvm-commits]

Hi Vedant,

Thanks for the comment.

Sure, that can be one way to proceed with this. But, besides the pretty-printing, this can encapsulate some other things regarding the debug location observation by adding new options to the tool, instead of putting all of that new functionalities inside the existing llvm-dwarfdump stats and overfill it with a lot of fields that operate only on the debug location info.

Best regards,
Djordje
 
-------- Original Message -------- 
Subject: Re: [PATCH] D65585: WIP: [llvm-locstats] Add the llvm-locstats tool 
Date: Thursday, August 1, 2019 19:33 CEST 
From: vsk at apple.com 
To: Adrian Prantl <aprantl at apple.com> 
CC: Djordje Todorovic <Djordje.Todorovic at rt-rk.com>,        David Blaikie <dblaikie at gmail.com>,        reviews+D65585+public+c79915da151b1549 at reviews.llvm.org,        Michał Górny <mgorny at gentoo.org>,        llvm-commits <llvm-commits at lists.llvm.org>,        Paul Robinson <paul.robinson at sony.com>, cHackz0x12 at gmail.com,        David Stenberg <david.stenberg at ericsson.com>, nikola.prica at rt-rk.com,        mattias.v.eriksson at ericsson.com, asowda at cisco.com,        Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>,        Son Tuan VU <sontuan.vu119 at gmail.com>,        Carlos Alberto Enciso <international.phantom at gmail.com>,        ewan at codeplay.com, jun.l at samsung.com, petar.jovanovic at mips.com,        Fangrui Song <maskray at google.com>, yuanfang.chen at sony.com,        Eric Christopher <echristo at gmail.com>, Reid Kleckner <rnk at google.com>,        Jonas Devlieghere <jonas at devlieghere.com>, orlando.hyams at sony.com,        Mikael Holmén <mikael.holmen at ericsson.com>,        Jeremy Morse <jeremy.morse.llvm at gmail.com>, chirag at raincode.com
References: <5b53-5d432080-7-58b62c80 at 97312848> <1D331949-09EA-4214-A199-A7D6F4D63538 at apple.com>
 
 
 
> 
> 
> > On Aug 1, 2019, at 10:27 AM, Adrian Prantl <aprantl at apple.com> wrote:
> > 
> > 
> > 
> >> On Aug 1, 2019, at 10:25 AM, Djordje Todorovic <Djordje.Todorovic at rt-rk.com> wrote:
> >> 
> >> I agree that the llvm-dwarfdump already has similar stats, but maybe it is worth of having a tool (maybe this can exist like a llvm-dwarfdump subtool) that reports some kind of verbose output and calculation on the debug location generated. If we want to have some observation only on the location list we can just add a new option to the subtool (i.e. the one for ignoring entry values), rather then putting new fields in to the existing llvm-dwarfdump statistic.
> > 
> > I'm not sure I follow, adding new fields to llvm-dwarfdump --statistics is cheap, what are we gaining be having it a separate tool?
> 
> I think the value of the proposed locstats (sub)tool comes from its pretty-printing support and its bucketing of location coverage by decile. There is a substantial functionality overlap with dwarfdump --statistics, though, so I think a good way to surface those new features might be with a flag (e.g. `llvm-dwarfdump --statistics --format=[json (default) | pretty]`).
> 
> vedant
> 
> > 
> > -- adrian
>