[PATCH] D65588: [MCA] Add support for printing immedate values as hex. Also enable lexing of masm binary and hex literals.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: tools/llvm-mca/llvm-mca.cpp:93
+    PrintImmHex("print-imm-hex", cl::cat(ToolOptions), cl::init(false),
+                cl::desc("Prefer hex format for immediate values"));
+
----------------
andreadb wrote:
> lebedev.ri wrote:
> > for *outputting* immediate values
> > This has no effect on input, right?
> Correct.
> 
> I can change it to "Prefer hex format for outputting immediate values".
> Alternatively, I could write "Prefer hex format when printing immediate values".
> Not sure which one is better.
"Prefer hex format when printing immediate values" IMHO


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65588/new/

https://reviews.llvm.org/D65588