[PATCH] D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin accepted this revision.
vpykhtin added a comment.
This revision is now accepted and ready to land.

LGTM, with tips :)



================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:533
 
-bool SILoadStoreOptimizer::findMatchingInst(CombineInfo &CI) {
-  MachineBasicBlock *MBB = CI.I->getParent();
-  MachineBasicBlock::iterator E = MBB->end();
-  MachineBasicBlock::iterator MBBI = CI.I;
+void SILoadStoreOptimizer::setMI(CombineInfo &CI,
+                                 MachineBasicBlock::iterator I) const {
----------------
This can be a member of CombineInfo, or even a constructor of it.


================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:606
+
+void SILoadStoreOptimizer::setPaired(CombineInfo &CI,
+                                     MachineBasicBlock::iterator I) const {
----------------
This can be a member of CombineInfo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65496/new/

https://reviews.llvm.org/D65496