[PATCH] D65463: [WebAssembly] Fix conflict between ret legalization and sjlj

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

In D65463#1607742 <https://reviews.llvm.org/D65463#1607742>, @aheejin wrote:

> I like this approach. I prefer the option 2 among the three options you described: 1 is redundantly doing what ISel is already doing, and 3 makes LLVM-backend generated code incorrect so we have to rely on the other tool to fix it, which seems not very desirable. As you said, having to add an extra argument to the interface of `CanLowerReturn` is a bit sad but I don't really mind that if others are OK with it.
>
> @dschuff @tlively Any more opinions?


I agree that this is the best direction to go in. It avoids duplicated effort and magic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65463/new/

https://reviews.llvm.org/D65463