[PATCH] D65189: [MC] Support returning a structured rich disassembly output
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 31 08:30:29 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/lib/MC/MCInstPrinter.cpp:145
+ // TODO: support tag-modifier-list. See:
+ // https://llvm.org/docs/MarkedUpDisassembly.html
+ size_t Length = 2 + TypeStr.size();
----------------
I suggest deleting this TODO. After rL166639 (2012), the document has never been touched. Actually, markup() has been adopted in every target so explicitly mentioning this may not be very necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65189/new/
https://reviews.llvm.org/D65189
More information about the llvm-commits
mailing list