[PATCH] D65156: [lit] Protect full test suite from FILECHECK_OPTS

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

I've noticed there is also an existing problem with `env` calling `env`: the former is executed by lit's internal shell, and the latter is an external command.  That happens in some lit tests due to this patch's `%{lit}` substitution, so my quick hack yesterday might not have fixed all test failures people experienced.

It seems this issue is not going to resolve quickly.  For the sake of the windows bots, I'm planning to revert this patch and r367123 (D65335 <https://reviews.llvm.org/D65335>) for now.  Let me know if you object.

I've started working on solutions, which seem to make lit's internal shell more robust anyway.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65156/new/

https://reviews.llvm.org/D65156