[PATCH] D64903: [ELF] Add -z separate-code and pad the last page of last PF_X PT_LOAD with traps only if -z separate-code is specified

Thu Aug 1 05:06:31 PDT 2019

MaskRay added a comment.

In D64903#1610003 <https://reviews.llvm.org/D64903#1610003>, @labath wrote:

> It seems this has broken some tests in lldb :/ http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7321. By the looks of things, the new layout of sections has triggered some kind of a debug_line parsing bug. I'm looking at whether there is an easy fix for that (I am hoping that there is one).

My bad.. I didn't know some lldb tests run ld.lld.. Non-SHF_ALLOC sections such as .comment, .symtab, and .shstrtab

Since you're already looking at them (and it seems you added these tests:) I'll not fix at the same time then. If the bug is not easy to fix, try adding `-z separate-code`.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64903/new/

https://reviews.llvm.org/D64903