[PATCH] D65570: [test/Object] - Cleanup the Object\obj2yaml.test a bit.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 04:58:52 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.

This makes 2 changes:

- Removes `unwind-section.elf-x86-64` object and the corresponding test case,

because `SHT_X86_64_UNWIND` is already tested here:
https://github.com/llvm-mirror/llvm/blob/master/test/tools/obj2yaml/section-type.yaml

- Removes/partially moves "No such file or directory" test, because  we already have a similar test here:

https://github.com/llvm-mirror/llvm/blob/master/test/tools/obj2yaml/invalid_input_file.test


https://reviews.llvm.org/D65570

Files:
  test/Object/Inputs/unwind-section.elf-x86-64
  test/Object/obj2yaml.test
  test/tools/obj2yaml/invalid_input_file.test


Index: test/tools/obj2yaml/invalid_input_file.test
===================================================================
--- test/tools/obj2yaml/invalid_input_file.test
+++ test/tools/obj2yaml/invalid_input_file.test
@@ -1,4 +1,3 @@
 # RUN: not obj2yaml  %p/path/does/not/exist 2>&1 | FileCheck %s
 
-# Don't check the OS-dependent message "No such file or directory".
-# CHECK: Error reading file: {{.*}}/path/does/not/exist: {{.*}}
+# CHECK: Error reading file: {{.*}}/path/does/not/exist: {{[Nn]}}o such file or directory
Index: test/Object/obj2yaml.test
===================================================================
--- test/Object/obj2yaml.test
+++ test/Object/obj2yaml.test
@@ -766,13 +766,3 @@
 # WASM-NEXT:         Flags:           [  ]
 # WASM-NEXT:       - Index:           1
 # WASM:      ...
-
-# RUN: obj2yaml %p/Inputs/unwind-section.elf-x86-64 | FileCheck %s --check-prefix ELF-X86-64-UNWIND
-
-# ELF-X86-64-UNWIND:      - Name:            .eh_frame
-# ELF-X86-64-UNWIND-NEXT:   Type:            SHT_X86_64_UNWIND
-# ELF-X86-64-UNWIND-NEXT:   Flags:           [ SHF_ALLOC ]
-# ELF-X86-64-UNWIND-NEXT:   AddressAlign:    0x0000000000000001
-
-# RUN: not obj2yaml %t.blah 2>&1 | FileCheck --check-prefix=ENOENT %s
-# ENOENT: Error reading file: {{.*}}.blah: {{[Nn]}}o such file or directory


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65570.212786.patch
Type: text/x-patch
Size: 1308 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190801/6c764572/attachment.bin>


More information about the llvm-commits mailing list