[PATCH] D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 21:29:04 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:6038
 
+static unsigned getBufferOffsetForMMO(const SDValue &VOffset,
+                                      const SDValue &SOffset,
----------------
Should get a comment


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:6039-6040
+static unsigned getBufferOffsetForMMO(const SDValue &VOffset,
+                                      const SDValue &SOffset,
+                                      const SDValue &Offset,
+                                      const SDValue *VIndex = nullptr) {
----------------
No references needed


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:6041
+                                      const SDValue &Offset,
+                                      const SDValue *VIndex = nullptr) {
+
----------------
No pointer needed, VIndex = SDValue()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65097/new/

https://reviews.llvm.org/D65097





More information about the llvm-commits mailing list