[PATCH] D65213: [ELF] With --vs-diagnostics, print a separate message for each location of a duplicate symbol.

Wed Jul 31 21:18:07 PDT 2019

ikudrin marked an inline comment as done.
ikudrin added inline comments.

================
Comment at: test/ELF/vs-diagnostics-duplicate.s:12
+// CHECK:      duplicate2.s(20): error: duplicate symbol: bar
+// CHECK-NEXT: >>> defined at duplicate2.s:20
+// CHECK-NEXT: >>>{{.*}}2.o:(.text+0x{{.+}})
----------------
ruiu wrote:
> What about this line? It seems that the second line (e.g. "defined at duplicate2.s:20") is always repeating the same location as the first line (e.g. "duplicate2.s(20: error: ...").
It is how your suggestion for `--vs-diagnostics` works, see D58484. This patch does nothing with that decision. It merely makes it possible to jump to the second location in VS IDE.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65213/new/

https://reviews.llvm.org/D65213