[PATCH] D65429: Improving CodeView debug info type record's inline comments

[NILANJANA BASU via Phabricator via llvm-commits]

nilanjana_basu updated this revision to Diff 212714.
nilanjana_basu marked 4 inline comments as done.
nilanjana_basu added a comment.

Changes made according to review feedback:

1. Moved EnumTables to EnumTables.cpp
2. Made attributes & properties print on the same line, in a more compact form (print only the ones that are enabled, & on the same line. Flags are "|" separated, & enums are comma-separated)
3. Restricted string formatting related computation to Streamer mode

Question: Have been updating the test files manually, so that the difference is clearly visible in the diff. However, because of this it does not take into account a lot of other changes in output, that also should be verified. Do you recommend updating the test files by a direct copy of the ASM?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65429/new/

https://reviews.llvm.org/D65429

Files:
  llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h
  llvm/include/llvm/DebugInfo/CodeView/EnumTables.h
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/DebugInfo/CodeView/CodeViewRecordIO.cpp
  llvm/lib/DebugInfo/CodeView/EnumTables.cpp
  llvm/lib/DebugInfo/CodeView/TypeRecordMapping.cpp
  llvm/test/DebugInfo/COFF/class-options-common.ll
  llvm/test/DebugInfo/COFF/types-basic.ll
  llvm/test/DebugInfo/COFF/types-data-members.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65429.212714.patch
Type: text/x-patch
Size: 52024 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190801/990487c1/attachment.bin>