[PATCH] D62434: [lld-link] diagnose undefined symbols before LTO when possible

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 16:57:48 PDT 2019


thakis added inline comments.


================
Comment at: lld/trunk/COFF/SymbolTable.cpp:329
+      continue;
+    if (Defined *d = undef->getWeakAlias())
+      continue;
----------------
A bot notices:

```
lld/COFF/SymbolTable.cpp:329:18: warning: unused variable ā€˜dā€™ [-Wunused-variable]
     if (Defined *d = undef->getWeakAlias())
                  ^
```

I'd just remove `d` but I'm not sure if you intended to do something with it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62434/new/

https://reviews.llvm.org/D62434





More information about the llvm-commits mailing list