[PATCH] D64834: [Xtensa 8/10] Add support of the Xtensa shift/load/store/move and processor control instructions.
Andrei Safronov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 31 16:51:52 PDT 2019
andreisfr marked an inline comment as done.
andreisfr added inline comments.
================
Comment at: llvm/lib/Target/Xtensa/AsmParser/XtensaAsmParser.cpp:132-134
bool isImm(int64_t MinValue, int64_t MaxValue) const {
return Kind == Immediate && inRange(getImm(), MinValue, MaxValue);
}
----------------
arsenm wrote:
> There are already various forms of isInt/isUInt in MathExtras.h
Did you mean do not create/use special functions isImm and inRange? Initially I used the same approach as in SystemZ and AArch64 architecture, because we need to check whether expression immediate and also get value of it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64834/new/
https://reviews.llvm.org/D64834
More information about the llvm-commits
mailing list