[PATCH] D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 212676.
wolfgangp marked 12 inline comments as done.
wolfgangp added a comment.

Addressed review comments:

- renamed one of the printStackSize() functions.
- removed superfluous check for nonrelocatable object
- Used SectionRef::getName() instead of the explicit sequence to extract a section name.
- Fixed the calls to the DataExtractor() constructor to use Obj->isLittleEndian()
- Added some comments to explain the error handling policy.
- Moved a SectionName variable definition closer to the use point.

Not resolved:
Left the question about whether --stack-sizes should be include in --all open. This is still a discussion point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65313/new/

https://reviews.llvm.org/D65313

Files:
  llvm/docs/CommandGuide/llvm-readelf.rst
  llvm/test/tools/llvm-readobj/stack-sizes.test
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.h
  llvm/tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65313.212676.patch
Type: text/x-patch
Size: 33013 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190731/5e0312c1/attachment.bin>