[PATCH] D55153: [ThinLTO] Implement index-based WPD

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 14:25:55 PDT 2019


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/LTO/LTO.cpp:48
 #include "llvm/Transforms/Utils/FunctionImportUtils.h"
+#include "llvm/Transforms/IPO/WholeProgramDevirt.h"
 #include "llvm/Transforms/Utils/SplitModule.h"
----------------
nit: sort


================
Comment at: test/ThinLTO/X86/devirt2.ll:200
+; in original (exporting) module.
+; REMARK-DAG-COUNT-2: single-impl: devirtualized a call to _ZN1E1mEi
+
----------------
Is `-DAG` supported with `-COUNT`? (Doesn't look like it: http://llvm-cs.pcc.me.uk/lib/Support/FileCheck.cpp#1046 )
I would just write this out twice.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55153/new/

https://reviews.llvm.org/D55153





More information about the llvm-commits mailing list