[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 13:41:12 PDT 2019


cameron.mcinally added a comment.

Thanks for pointing this out, Craig. I do see `VisitUnaryMinus(...)` now. [I'm glad that Clang distinguished between the unary and binary fneg -- that could've been trouble. ;)]

Kind of a larger question: Do we want to include the VisitUnaryMinus change into one mega-Diff? Or should we have several separate Diffs for each of the individual `CreateFNeg(...)` changes?

One mega-diff would probably be better for shaking out any performance problems. But it will also make the changeset much larger with test differences.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675





More information about the llvm-commits mailing list