[PATCH] D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer.

[Sumedh Arani via Phabricator via llvm-commits]

aranisumedh updated this revision to Diff 212657.
aranisumedh added a comment.

Thank you for valuable inputs. Sorry for the delay in getting back to you.

I have mostly used asserts() to capture bad inputs. I have not yet added tests to test for bad input. Google test had documentation using AssertionSuccess() and AssertionFailure(). [https://github.com/google/googletest/blob/master/googletest/docs/advanced.md]. Do I use that or you've something else in mind?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64095/new/

https://reviews.llvm.org/D64095

Files:
  llvm/include/llvm/Analysis/SearchVectorFunctionSystem.h
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/LinkAllPasses.h
  llvm/lib/Analysis/Analysis.cpp
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/Analysis/SearchVectorFunctionSystem.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/unittests/Analysis/CMakeLists.txt
  llvm/unittests/Analysis/SearchVectorFunctionSystemTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64095.212657.patch
Type: text/x-patch
Size: 38157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190731/4c08abe6/attachment-0001.bin>