[llvm] r367477 - [GISel] Address review feedback on passing MD_callees to lowerCall.

Mark Lacey via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 13:34:05 PDT 2019


Author: rudkx
Date: Wed Jul 31 13:34:05 2019
New Revision: 367477

URL: http://llvm.org/viewvc/llvm-project?rev=367477&view=rev
Log:
[GISel] Address review feedback on passing MD_callees to lowerCall.

Preserve the nullptr default for KnownCallees that appears in
the base class.

Modified:
    llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h
    llvm/trunk/lib/Target/ARM/ARMCallLowering.h
    llvm/trunk/lib/Target/Mips/MipsCallLowering.h
    llvm/trunk/lib/Target/X86/X86CallLowering.h

Modified: llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h?rev=367477&r1=367476&r2=367477&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h Wed Jul 31 13:34:05 2019
@@ -43,12 +43,12 @@ public:
   bool lowerCall(MachineIRBuilder &MIRBuilder, CallingConv::ID CallConv,
                  const MachineOperand &Callee, const ArgInfo &OrigRet,
                  ArrayRef<ArgInfo> OrigArgs, Register SwiftErrorVReg,
-                 const MDNode *KnownCallees) const override;
+                 const MDNode *KnownCallees = nullptr) const override;
 
   bool lowerCall(MachineIRBuilder &MIRBuilder, CallingConv::ID CallConv,
                  const MachineOperand &Callee, const ArgInfo &OrigRet,
                  ArrayRef<ArgInfo> OrigArgs,
-                 const MDNode *KnownCallees) const override {
+                 const MDNode *KnownCallees = nullptr) const override {
     return lowerCall(MIRBuilder, CallConv, Callee, OrigRet, OrigArgs, 0,
                      KnownCallees);
   }

Modified: llvm/trunk/lib/Target/ARM/ARMCallLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMCallLowering.h?rev=367477&r1=367476&r2=367477&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMCallLowering.h (original)
+++ llvm/trunk/lib/Target/ARM/ARMCallLowering.h Wed Jul 31 13:34:05 2019
@@ -41,7 +41,7 @@ public:
   bool lowerCall(MachineIRBuilder &MIRBuilder, CallingConv::ID CallConv,
                  const MachineOperand &Callee, const ArgInfo &OrigRet,
                  ArrayRef<ArgInfo> OrigArgs,
-                 const MDNode *KnownCallees) const override;
+                 const MDNode *KnownCallees = nullptr) const override;
 
 private:
   bool lowerReturnVal(MachineIRBuilder &MIRBuilder, const Value *Val,

Modified: llvm/trunk/lib/Target/Mips/MipsCallLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsCallLowering.h?rev=367477&r1=367476&r2=367477&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsCallLowering.h (original)
+++ llvm/trunk/lib/Target/Mips/MipsCallLowering.h Wed Jul 31 13:34:05 2019
@@ -71,7 +71,7 @@ public:
   bool lowerCall(MachineIRBuilder &MIRBuilder, CallingConv::ID CallConv,
                  const MachineOperand &Callee, const ArgInfo &OrigRet,
                  ArrayRef<ArgInfo> OrigArgs,
-                 const MDNode *KnownCallees) const override;
+                 const MDNode *KnownCallees = nullptr) const override;
 
 private:
   /// Based on registers available on target machine split or extend

Modified: llvm/trunk/lib/Target/X86/X86CallLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86CallLowering.h?rev=367477&r1=367476&r2=367477&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86CallLowering.h (original)
+++ llvm/trunk/lib/Target/X86/X86CallLowering.h Wed Jul 31 13:34:05 2019
@@ -37,7 +37,7 @@ public:
   bool lowerCall(MachineIRBuilder &MIRBuilder, CallingConv::ID CallConv,
                  const MachineOperand &Callee, const ArgInfo &OrigRet,
                  ArrayRef<ArgInfo> OrigArgs,
-                 const MDNode *KnownCallees) const override;
+                 const MDNode *KnownCallees = nullptr) const override;
 
 private:
   /// A function of this type is used to perform value split action.




More information about the llvm-commits mailing list