[PATCH] D63378: [ORC] WIP Speculative compilation

[Praveen velliengiri via Phabricator via llvm-commits]

pree-jackie marked 3 inline comments as done.
pree-jackie added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/Orc/Speculation.h:163-170
+  template <
+      typename AnalysisTy,
+      typename std::enable_if<
+          std::is_base_of<AnalysisInfoMixin<AnalysisTy>, AnalysisTy>::value,
+          bool>::type = true>
+  void registerAnalysis() {
+    FAM.registerPass([]() { return AnalysisTy(); });
----------------
lhames wrote:
> I think this should be able to be removed now?
I tend to keep this interface, because it helps us to register analysis which uses already available LLVM pass results, without this,  it may cumbersome at the client code (SpeculativeJIT). 
Let's keep it, and see if it is not worthy we can kill this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63378/new/

https://reviews.llvm.org/D63378