[PATCH] D65156: [lit] Protect full test suite from FILECHECK_OPTS
Michał Górny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 31 10:53:00 PDT 2019
mgorny added a comment.
In D65156#1608751 <https://reviews.llvm.org/D65156#1608751>, @jdenny wrote:
> After debugging more on my system, it seems that `not` in front of a `%{lit}` causes lit's internal shell to use an external `env` instead of the internal `env`. Fine for ubuntu. Not fine for windows. Will post more later.
Yeah, that makes sense. Since `not` is an external program, it obviously does not use the internal shell.
I would suggest moving the `env` calls into a separate substitution, and moving them always to the front.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65156/new/
https://reviews.llvm.org/D65156
More information about the llvm-commits
mailing list