[PATCH] D65521: [LLVM][Alignment] Introduce Alignment Type in DataLayout

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet marked an inline comment as done.
gchatelet added inline comments.


================
Comment at: llvm/include/llvm/IR/DataLayout.h:269
 
-  unsigned getStackAlignment() const { return StackNaturalAlign; }
+  unsigned getStackAlignment() const { return StackNaturalAlign ? StackNaturalAlign->value() : 0; }
   unsigned getAllocaAddrSpace() const { return AllocaAddrSpace; }
----------------
jfb wrote:
> Return `MaybeAlign` here? Or in a future patch?
Touching interfaces of widely used types is very contaminating and pulling the string leads to huge patches that are hard to review.
My rough plan is the following:
 - Change the implementation details of the widely used types but don't touch the interface if it triggers too much changes
 - Change the leaves implementations, e.g. llvm/lib/Target/XXX. The changes here should be self contained.
 - Change interfaces of widely used types, one interface at a time.

I'll have a look at what it takes to include it in this patch and report back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65521/new/

https://reviews.llvm.org/D65521