[PATCH] D64179: [CodeGen] Define an interface for the new pass manager.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/PassManager.h:86-88
+    if (ShouldEmitSizeRemarks) {
+      // We wanted size remarks. Check if there was a change to the number of
+      // MachineInstrs in the module. Emit a remark if there was a change.
----------------
fedor.sergeev wrote:
> If you do want to emit size remarks after each machine-function pass then its best to be done through pass instrumentation.
> Since you do not implement pass instrumentation right now, skip this code as well.
Size remarks aren't supported in the new PM at all right now. I'm not entirely sure that this would work. (Testcase?)

It would be nice to have a port that would work for both codegen and IR-level passes though. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64179/new/

https://reviews.llvm.org/D64179