[PATCH] D62432: [SLPVectorizer] Make the scheduler aware of the TreeEntry operands.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1667
+        // Decrement the unscheduled counter and insert to ready list if ready.
+        auto decrUnsched = [this, &ReadyList](Instruction *I) {
           doForAllOpcodes(I, [&ReadyList](ScheduleData *OpDef) {
----------------
`auto &&DecrUnshed`


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1695-1696
+          }
+        }
+        else {
+          // If BundleMember is a stand-alone instruction, no operand reordering
----------------
Bad formatting here


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4345
   if (isa<PHINode>(S.OpValue))
-    return true;
+    return Optional<BoUpSLP::ScheduleData *>(nullptr);
 
----------------
`return nullptr;`


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4427
   }
-  return true;
+  return Optional<BoUpSLP::ScheduleData *>(Bundle);
 }
----------------
`return Bundle;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62432/new/

https://reviews.llvm.org/D62432