[PATCH] D65512: gn build: Fix redundant object files in builtin lib.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 06:54:16 PDT 2019


thakis created this revision.
thakis added reviewers: phosek, mstorsjo.
Herald added subscribers: kristof.beyls, javed.absar, mgorny.
Herald added a project: LLVM.

compiler-rt's builtin library has generic implementations of many
functions, and then per-arch optimized implementations of some.

In the CMake build, both filter_builtin_sources() and an explicit loop
at the end of the build file (see D37166 <https://reviews.llvm.org/D37166>) filter out the generic
versions if a per-arch file is present.

The GN build wasn't doing this filtering. Just do the filtering manually
and explicitly, instead of being clever.

While here, also remove files from the mingw/arm build that are
redundantly listed after D39938 <https://reviews.llvm.org/D39938> / r318139 (both from the CMake and the
GN build).


https://reviews.llvm.org/D65512

Files:
  compiler-rt/lib/builtins/CMakeLists.txt
  llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65512.212570.patch
Type: text/x-patch
Size: 4954 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190731/21a43fd4/attachment.bin>


More information about the llvm-commits mailing list