[PATCH] D65191: [llvm-objdump] Implement highlighting

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2290
+  ColorsEnabled =
+      WithColor::isColorOptionSet() && WithColor::colorsAvailable(outs());
+
----------------
MaskRay wrote:
> `WithColor::isColorOptionSet() && outs().has_colors()`
Place `extern cl::opt<cl::boolOrDefault> UseColor;` at toplevel.

`ColorsEnabled = UseColor == cl::BOU_UNSET;` may be simpler


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65191/new/

https://reviews.llvm.org/D65191