[PATCH] D65506: [MachineScheduler] improve reuse of 'releaseNode'method

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 04:14:10 PDT 2019


fhahn added reviewers: fhahn, atrick.
fhahn added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:2109
     Available.push(SU);
+    if (IsPQueue) Pending.remove(Pending.begin() + Idx);
+    return;
----------------
Having the statement on the same line looks a bit unusual. Could you clang-format-diff it?


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:2361
-
-    if (Available.size() >= ReadyListLimit)
-      break;
----------------
The new code is is missing this condition and Available.size() may exceed ReadyListLimit I think.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65506/new/

https://reviews.llvm.org/D65506





More information about the llvm-commits mailing list