[PATCH] D64790: [LLVM][NFC] Adding an Alignment type to LLVM

Wed Jul 31 00:44:13 PDT 2019

gchatelet marked 3 inline comments as done.
gchatelet added a comment.

Thank you for the review @jfb and @jakehehrlich. I'll submit the patch now and start working on the migration.
Let me know if you have additional comments.

================
Comment at: llvm/include/llvm/Support/Alignment.h:40
+// It is suitable for use as static global constants.
+struct Align final {
+private:
----------------
jfb wrote:
> gchatelet wrote:
> > jfb wrote:
> > > `final` is kinda weird here. Not that I'd inherit from this... but why have `final`?
> > It was a way to document that this type is not to be derived from. It does not have a virtual destructor.
> > Now I don't have a strong opinion and I'm happy to remove it if you think it's too weird.
> > 
> It's just not something we really do anywhere.
I removed the `final` here and below.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64790/new/

https://reviews.llvm.org/D64790