[PATCH] D65499: [ELF] Fix finding the location in messages for undefined hidden symbols.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: Common/ErrorHandler.cpp:99
       std::regex(
-          R"(^undefined (internal|hidden|protected) symbol: .*\n>>> referenced by (\S+):(\d+)\n.*)"),
+          R"(^undefined (?:internal|hidden|protected) symbol: .*\n>>> referenced by (\S+):(\d+)\n.*)"),
       std::regex(R"((\S+):(\d+): unclosed quote)"),
----------------
ruiu wrote:
> Or maybe you can relax this parentheses to `\S+`.
If you use `R"(^undefined (?:internal |hidden |protected |)symbol: .*\n>>> referenced by (\S+):(\d+)\n.*)"`, this can be merged with `undefined symbol` above...


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65499/new/

https://reviews.llvm.org/D65499