[PATCH] D65470: [WebAssembly] Fix allocsize attribute in sjlj lowering

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 22:33:31 PDT 2019


aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

Thank you! LGTM if land D65463 <https://reviews.llvm.org/D65463>.



================
Comment at: llvm/test/CodeGen/WebAssembly/lower-em-sjlj.ll:207
+; Test that the allocsize attribute is being transformed properly
+declare void @allocator(i32, %struct.__jmp_buf_tag*) #3
+define hidden void @allocsize() {
----------------
Real nit: Doesn't matter for this test case, but maybe it would make more sense for this file to return `i8*`, because it has `allocsize` attribute


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65470/new/

https://reviews.llvm.org/D65470





More information about the llvm-commits mailing list