[PATCH] D65430: Add `--write-dependencies` option, which is equivalent to compiler option -MD.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu marked an inline comment as done.
ruiu added inline comments.


================
Comment at: lld/ELF/Options.td:416
 
+defm write_dependencies: Eq<"write-dependencies", "Write a dep file">,
+  MetaVarName<"<path>">;
----------------
phosek wrote:
> Have you considered naming the option `-dependency-file`? That's the name of the CC1 flag (see https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Driver/Options.td#L606) and I think it'd be nice to make those consistent across different tools.
No, but that's a good suggestion. `--write-dependencies`, which is an alias for `-MD`, is also taken from clang, but in clang, that option doesn't take an argument. Clang's `-dependency-file` takes an argument. So, for consistency, it seems like `-dependency-file` is a better name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65430/new/

https://reviews.llvm.org/D65430