[PATCH] D63459: Loop Cache Analysis

Tue Jul 30 15:47:52 PDT 2019

fhahn added a comment.

In D63459#1607143 <https://reviews.llvm.org/D63459#1607143>, @etiotto wrote:

> In D63459#1605923 <https://reviews.llvm.org/D63459#1605923>, @fhahn wrote:
>
> > Can you re-run clang-format on the latest version of the patch? I think it would be good to get an in-tree user of this soon, to make sure the modeling works as expected on real hardware/benchmarks. Do you have a timeline to get this used? I think you mentioned LoopFusion as one of the first planned users?
>
>
> I reformatted the patch and addressed inline comments. The paper reports that the analysis was used to guide both loop fusion and loop interchange. I used it myself profitably on loop interchange (not yet in tree), and the lit tests provided are based in part on that experiment.

Right, are you planning on submitting a patch for loop interchange upstream?

I used the printer on some of the loop interchange tests, but the delinearization does not support some cases there yet. I hope I find some time to look into that next week and maybe also integrating it into loop interchange unless you plan to do so.

> If there are not further comments and/or concerns I'll commit the patch on Thursday.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63459/new/

https://reviews.llvm.org/D63459