[PATCH] D64185: [NewPM] Port FinalizeISel to the new pass manager.
Charles Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 30 14:33:52 PDT 2019
czhang marked 2 inline comments as done.
czhang added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/FinalizeISel.h:25-30
+struct FinalizeISelPass : PassInfoMixin<FinalizeISelPass> {
+ PreservedAnalyses run(MachineFunction &MF, MachineFunctionAnalysisManager &);
+};
+} // namespace llvm
+
+#endif // LLVM_CODEGEN_FINALIZE_ISEL_H
----------------
arsenm wrote:
> Should these pass headers be sorted into an include/llvm/CodeGen/Passes directory?
Since the non-codegen passes in Analysis/ and Transform/ have their equivalent headers under paths corresponding to the implementation files, I think it is better to leave it like this for consistency with the normal IR passes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64185/new/
https://reviews.llvm.org/D64185
More information about the llvm-commits
mailing list