[PATCH] D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 12:58:26 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

One issue, but otherwise this looks good to me.



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:275
+    CallSiteInfo CSInfo;
+    MDNode *HeapAllocSite;
+  };
----------------
Use `= nullptr` here so that any default constructed entries don't appear to have heap alloc sites. This would happen when there is CallSiteInfo for a call site, but no heap alloc site.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61105/new/

https://reviews.llvm.org/D61105





More information about the llvm-commits mailing list