[PATCH] D65468: [NVPTX] Fix PR41651
Michael Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 30 12:47:34 PDT 2019
hliao marked an inline comment as done.
hliao added inline comments.
================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:1296
+ retTy->isIntegerTy(128)) {
+ auto &DL = CS.getParent()->getModule()->getDataLayout();
O << ".param .align " << retAlignment << " .b8 _["
----------------
hliao wrote:
> tra wrote:
> > Can we just use `DAG.getDataLayout()` as we do everywhere else?
> Unfortunately, either DAG or CLI (CallLoweringInfo) is not passed as parameter. Without changing prototype of that function, get data layout from CS is the trivial way.
Wait, DL is passed as parameter, I will simplify the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65468/new/
https://reviews.llvm.org/D65468
More information about the llvm-commits
mailing list