[PATCH] D63972: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 30 12:30:04 PDT 2019
efriedma added a comment.
> Here, if I use F->erase(TBB), the memory leak error is still existed.
What exactly is leaking? (If you're calling erase(), it isn't the MBB itself.)
Of course, that isn't a substitute for calling `FunctionChain.remove` etc.
Looking over this patch again, some of the other work involved in updating various data structures isn't complete here; the MachineDominatorTree/MachinePostDominatorTree isn't updated, MachineLoopInfo isn't updated.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63972/new/
https://reviews.llvm.org/D63972
More information about the llvm-commits
mailing list