[PATCH] D65324: [ARM][ParallelDSP] Convert to function pass
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 30 12:09:24 PDT 2019
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:192
AU.addRequired<AssumptionCacheTracker>();
AU.addRequired<ScalarEvolutionWrapperPass>();
AU.addRequired<AAResultsWrapperPass>();
----------------
Missing call to `AU.addPreserved<ScalarEvolutionWrapperPass>()`. Missing call to `AU.addPreserved<GlobalsAAWrapperPass>()`. But that's orthogonal, I guess; fine to address that in a followup.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65324/new/
https://reviews.llvm.org/D65324
More information about the llvm-commits
mailing list