[PATCH] D65364: AArch64: Add a tagged-globals backend feature.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:231
 
+  // References to tagged globals are marked with MO_NC to indicate that their
+  // nominal addresses are outside of the code model. In
----------------
pcc wrote:
> ostannard wrote:
> > I don't really like the idea of re-using MO_NC to mean something more complex/specialised than the description in AArch64BaseInfo.h, maybe it would be better to add a new value (MO_TAGGED) to represent this?
> That would be fine with me, but we currently only have 12 bits of storage for the target flags and I didn't want to take another one unnecessarily.
Done; this required fixing a silent truncation of flags above bit 8 in D65465.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65364/new/

https://reviews.llvm.org/D65364