[PATCH] D65242: [ELF] More dynamic relocation packing

[Vic Yang via Phabricator via llvm-commits]

victoryang marked 4 inline comments as done.
victoryang added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:1693
+  // enables us to group by r_addend as well.
+  llvm::sort(nonRelatives, [](const Elf_Rela &a, const Elf_Rela &b) {
+    if (a.r_info != b.r_info)
----------------
ruiu wrote:
> I believe you need to use `llvm::stable_sort` for build reproducibility.
Ah you are right. I copied llvm::sort from above but missed that this has non-unique keys.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65242/new/

https://reviews.llvm.org/D65242