[PATCH] D65156: [lit] Protect full test suite from FILECHECK_OPTS

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

This actually breaks the lit tests on Windows when the path to Python has spaces. For example:

  Command Output (stdout):
  --
  $ ":" "RUN: at line 3"
  note: command had no output on stdout or stderr
  $ "not" "env" "FILECHECK_OPTS=" "FILECHECK_DUMP_INPUT_ON_FAILURE=" "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe" "E:/_work/18/s/llvm\utils\lit\lit.py" "-j" "1" "-v" "E:/_work/18/b/utils/lit/tests\Inputs/shtest-output-printing"
  # command stderr:
  C:\Program: can't open file 'Files': [Errno 2] No such file or directory


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65156/new/

https://reviews.llvm.org/D65156