[PATCH] D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:649
+  int16_t SectNum = getSectionNumber();
+  Expected<DataRefImpl> SI = OwningObjectPtr->getSectionByNum(SectNum);
+  if (!SI)
----------------
sfertile wrote:
> If we fail to find a section, then should a StorageMappingClass of `XMC_PR` be enough to determine the symbol is a function?
In a single .o file, then maybe XMC_PR is enough to determine the symbol is a function. 
But I'm not sure if that's the case for a executable/dynamic library where linker could regroup the functions in a different way.  
I'm open to suggestions if there is a better way to do this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65240/new/

https://reviews.llvm.org/D65240