[PATCH] D65364: AArch64: Add a tagged-globals backend feature.

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 08:16:10 PDT 2019


ostannard added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:231
 
+  // References to tagged globals are marked with MO_NC to indicate that their
+  // nominal addresses are outside of the code model. In
----------------
I don't really like the idea of re-using MO_NC to mean something more complex/specialised than the description in AArch64BaseInfo.h, maybe it would be better to add a new value (MO_TAGGED) to represent this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65364/new/

https://reviews.llvm.org/D65364





More information about the llvm-commits mailing list