[PATCH] D64179: [CodeGen] Define an interface for the new pass manager.

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev requested changes to this revision.
fedor.sergeev added a comment.
This revision now requires changes to proceed.

This definitely needs unit tests.
Please, check llvm/unittests/IR/PassManagerTest.cpp for Function/Module unit tests, and, say, llvm/unittest/Analysis/LoopPassManagerTest.cpp for Loop unit tests.



================
Comment at: llvm/include/llvm/CodeGen/PassManager.h:86-88
+    if (ShouldEmitSizeRemarks) {
+      // We wanted size remarks. Check if there was a change to the number of
+      // MachineInstrs in the module. Emit a remark if there was a change.
----------------
If you do want to emit size remarks after each machine-function pass then its best to be done through pass instrumentation.
Since you do not implement pass instrumentation right now, skip this code as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64179/new/

https://reviews.llvm.org/D64179